[forest000014] Week 04 #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Jan 2, 2025
Comment on lines
15
to
22
| while (true) { | ||
| if (list1 == null) { | ||
| curr.next = list2; | ||
| break; | ||
| } else if (list2 == null) { | ||
| curr.next = list1; | ||
| break; | ||
| } |
There was a problem hiding this comment.
while(true) 대신에 while(list1 != null && list2 != null) 을 조건문으로 사용하고 내부 if ~ else를 while문이 끝난 후에 사용하는 방법도 있을것 같습니다!
There was a problem hiding this comment.
아하... 그렇게 하는 게 좀 더 논리가 명확하겠네요!
사실 처음부터 while(true)로 짰던 것은 아니고, 최대한 불필요한 조건문을 줄이고 줄이다 보니 지금 코드가 나오게 되었는데요,
코드를 다시 읽어보니 이 조건문이 언제 종료가 되는 것인지, 항상 종료가 되긴 하는 것인지가 한 눈에 직관적으로 이해되지는 않을 수 있겠네요
제안해 주신 아이디어대로 수정해보겠습니다 😄
|
@TonyKim9401 안녕하세요! 못 풀었던 문제까지 마저 풀어서 리뷰 요청드렸습니다 :) 시간 되실 때 한번 검토 부탁드립니다 🙇 |
TonyKim9401
reviewed
Jan 4, 2025
| ListNode head = new ListNode(); | ||
| ListNode curr = head; | ||
|
|
||
| while (list1 != null && list2 != null) { |
SamTheKorean
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.